Conversation
This commit does the following: 1. Renames the `string_m` module and `string` function to `fortran_stringify_integer_m` and `fortran_stringify_integer`, respectively, to decrease the likelihood of name clashes with user code and to clarify the function's limited purpose. 2. Renames the `STRINGIFY` macro to `CPP_STRINGIFY_SOURCE` to more clarify the difference from `fortran_stringify_integer`. 3. Changes the `fortran_stringify_integer` string-writing format from `*` to `(i0)` for more consistent results across compilers. The results are the same for the three tested compilers: GCC (`gfortran`), NAG (`nagfor`), and LLVM (`flang-new`).
This commit adds comments to the assert_m module to clarify the purpose of the fortran_stringify_integer function and refer users to Julienne for a more broadly useful stringification capability.
This commit updates the README.md file to explain that two experimental flags required with LLVM 19 are not required with LLVM 20.
Member
|
Not sure if there was some external pressure motivating a rush on this PR, but I would have appreciated the opportunity to review it before merge, and especially before tagging it as a new release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request accomplishes the following:
string_mmodule andstringfunction tofortran_stringify_integer_mandfortran_stringify_integer, respectively, to decrease the likelihood of name clashes with user code and to clarify the function's limited purpose.assert_mmodule to clarify the purpose of thefortran_stringify_integerfunction and refer users to Julienne for a more broadly useful stringification capability.STRINGIFYmacro toCPP_STRINGIFY_SOURCEto clarify the difference fromfortran_stringify_integerand reduce the likelihood of name clashes with user code.fortran_stringify_integerstring-writing format from*to(i0)for more consistent results across compilers. The results are the same for the three tested compilers: GCC (gfortran), NAG (nagfor), and LLVM (flang-new).